New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Fix undefined offset: 1 #17139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an appropriate correction. On code review and preg_match testing
@rdeutz I have two v3.7.3 installs where the second install has this PR. The first install is littered with |
There are no unit tests for |
@photodude I don't know how to do it. Would you mind doing it? Thanks. |
@mbabker I'll put a list together for that PR. |
@Quy can you fix the merge conflict |
Hello |
@Brian5600 Please mark it a successful test here: https://issues.joomla.org/tracker/joomla-cms/17139 |
@Quy i altered successfully Test for @Brian5600 |
@franz-wohlkoenig @Quy thanks. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17139. |
@photodude who is second successfully Test? |
@franz-wohlkoenig I guess I miss read it, I thought you had done a test. Really this is a "by code review" item as there is no good/easy way to test this and there are not really any unit tests for it either. I'll mark approved by code review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved by code review
RTC after two successful tests. |
@photodude i altered your Review as successfully Test at Issue Tracker. |
Pull Request for Issue #16970 .
Fix regression for Issue #15228 .
Summary of Changes
Revert to previous individual preg_match rather than combine them into 1.
Testing Instructions
Check your PHP error log.
or
Create the following PHP script and run it. 1st preg_match( (previous) outputs no error. 2nd preg_match( (current) outputs error.
results (1st array is v3.6.5 and 2nd array is v3.7.3):
Expected result
No PHP Notice
Actual result
Documentation Changes Required
None